Facets overview rendering strangeness in Edge browser.
minimaxir opened this issue · comments
From loading the Quick, Draw demo in macOS 12.10.5 / Safari 10.1.1. (also occurs on Safari iOS).
Thanks for bringing this to our attention. We were able to reproduce that the demos don't work in Safari. For now, you can workaround by viewing them in Chrome. Will fix for Safari ASAP.
It seems I have the same problem with Firefox 54.0 & Ubuntu 16.04. The Jupyter Overview_demo renders no output as well.
Cannot view demo in Microsoft Edge (Windows 10), either.
Object doesn't support property or method 'getStatsProto'
facets (286,5)
@mg1075 @valentas-kurauskas @minimaxir please try the demo pages again on your non-chrome browsers.
I updated the gh-pages branch demo code that drives the demo pages (see commit c436483). The code now loads the webcomponents-lite polyfill (to support browsers that don't have the webcomponents standard built-in) and only loads the facets code once the polyfill is loaded.
It will still be the case that using the visualizations in jupyter will only currently work in Chrome, but the demo pages should be cross-browser compatible now.
@jameswex - Microsoft Edge, Windows 10:
the visualizations do show up now.
I see odd behavior with the "log | expand | percentages" menu.
First it shows at top. The "Chart to show" option is not visible.
Then if I click a checkbox, the section moves to its normal spot, and the "Chart to show" option becomes visible.
Here's a view from the console.
Changed the title of this issue as the initial issue is solved and now the remaining issue is an issue with some of the control positions in the Edge browser.
@jameswex Firefox 57, Debian Linux:
The demo page works for me (https://pair-code.github.io/facets/) but the jupyter notebook integration doesn't display at all for me.
@jeremysalwen do you have errors in your developers console (assuming you are in chrome?)? Most likely the facets-dist jupyter extension wasn't installed in the place that the code in that notebook is expecting.
@jameswex I am on Firefox 57, I will check for console errors tomorrow.
The only issue I could see are the downloading of the of fonts, but the page looks fine on Firefox 99.0.1 (64-bit) Windows
