OzzyCzech / cmd-dialog

Command dialog and keyboard shortcuts palette for web apps.

Home Page:https://cmd-dialog.vercel.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dark mode - icons not visible

PhilETaylor opened this issue · comments

When the theme is dark the chosen icons are black on dark background making them hard to see.

ScreenShot-2023-05-19-10 21 28

There should be fill="currentColor" or stroke="currentColor" parameter for every icon that you use.

Check for example https://heroicons.com/

<svg
  xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" 
  stroke-width="1.5"
  stroke="currentColor"
  class="w-6 h-6">
  <path stroke-linecap="round" stroke-linejoin="round" d="M3.75 5.25h16.5m-16.5 4.5h16.5m-16.5 4.5h16.5m-16.5 4.5h16.5" />
</svg>

Awesome - that works perfectly. Using fontawesome icon svgs and just pasting in fill="currentColor" fixes this

To be clear, not looking for support :-) Happy to sponsor as well (although I see no sponsor button for your GitHub account?)

ScreenShot-2023-05-19-10 33 11