Running tea with Melange

Question

Running tea with Melange

idkjs opened this issue 3 years ago · comments

Alain Armand commented 3 years ago

Hi @OvermindDL1

I tried building something with this and running the program gets you the error main is not a function

Here is a reproduction -> feluxe/bs-tea-starter-kit#3

The error occurs on the example and on Usage.re which is copied from these docs.

Thanks for any guidance.

OvermindDL1 · Answer 1 · Tue Jun 29 2021 01:25:06 GMT+0800 (China Standard Time)

I'm not really sure I can recommend using this project for new code since bucklescript's changes over the past year have broken a lot of various things, it seems to be going more toward a non-ocaml setup rather than something that transparently handles all setups. I'll accept a PR if you find a fix for this (or if you want to take up overall work then I can give full access), but I'm not sure it's worth trying to "upgrade" to a newer bs-platform version. If you use bs-platform things you might want to stick with the older versions that implement to OCaml more correctly. Otherwise JSOO has some fantastic tea-like API's as well.

Alain Armand · Answer 2 · Tue Jun 29 2021 06:17:09 GMT+0800 (China Standard Time)

@OvermindDL1 I hear it. I might see how far the upgrade goes version by version of bucklescript and try to figure it out. Mostly because there is a lot of value in this project as an example of what is possible. Hate to see it get mothballed. Thanks for the feedback. I will revert if I get anywhere.

Alain Armand · Answer 3 · Sat Jul 03 2021 22:30:22 GMT+0800 (China Standard Time)

@jayesh-bhoot has it working here https://github.com/jayesh-bhoot/spiced-tea. FYI.

OvermindDL1 · Answer 4 · Thu Jul 22 2021 00:11:11 GMT+0800 (China Standard Time)

@idkjs If it's working there then that's still using a main function, what changed in the BS api?

Please feel free to PR any fixes though!

Jayesh Bhoot · Answer 5 · Thu Jul 22 2021 03:28:17 GMT+0800 (China Standard Time)

I agree with @OvermindDL1 .

All I did in https://github.com/jayesh-bhoot/spiced-tea was to make bucklescript-tea work with melange, and document that. The API works as-is.

I don’t see why anything should change in this repo, may be except documenting the integration with melange.

Thomas Coopman · Answer 6 · Sun Jul 25 2021 16:50:55 GMT+0800 (China Standard Time)

I can confirm that everything works as-is with melange. I've also created a sample repo that integrates with dream and adds tailwindcss: https://github.com/tcoopman/dream-melange-tea-tailwind

OvermindDL1 · Answer 7 · Tue Jul 27 2021 06:45:04 GMT+0800 (China Standard Time)

I'm really curious if someone could figure out what's the different in OP's example then, I wonder if there might be a compat issue then....