OriginProtocol / origin

Monorepo for our developer tools and decentralized marketplace application

Home Page:https://www.originprotocol.com/developers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't Delete Listing

micahalcorn opened this issue Β· comments

I seem to recall this being an issue related to the listing having been created without the proxy account or something. This certainly isn't a problem across all listings. Here is the reversion and this is the listing. πŸ˜•


At Origin, we use ZenHub to manage our engineering tasks and product development. Download their browser extension and check out our open workspace at github.com/originprotocol/origin#zenhub.

Revert is actually Must be depositManager

Listing shows this:

seller: '0xEdd31fBe930f851D551873cfe4d1def1fE97Cc75',
deposit: '0',
depositManager: '0x468e625dFD7a1aeb3F4F8B4544a7cA9A8Ad81f00'

user addresses:

from:  0x468e625dFD7a1aeb3F4F8B4544a7cA9A8Ad81f00
proxyAddress:  0xEdd31fBe930f851D551873cfe4d1def1fE97Cc75

Your recollection appears correct. It's sending via the proxy when the listing's depositManager is set to the real account, even though the seller is set to the proxy... kinda screwy.

@mikeshultz is there anything we can do about it, if even manually for this one listing? 😐

You can try running this in the console:

Marketplace.methods.withdrawListing(3118, '0x468e625dFD7a1aeb3F4F8B4544a7cA9A8Ad81f00', '0x17a7d0b206f30acd861773aace102ab35f41d2a0916aef975b2809d0b3ced1a8').send({ from: '0x468e625dFD7a1aeb3F4F8B4544a7cA9A8Ad81f00' })

send() might need some other parms, so hmu in discord if that fails.

Making a note and closing this with the manual fix ❌

context.marketplaces['000'].contractExec.methods.withdrawListing(3118, '0x468e625dFD7a1aeb3F4F8B4544a7cA9A8Ad81f00', '0x17a7d0b206f30acd861773aace102ab35f41d2a0916aef975b2809d0b3ced1a8').send({ from: '0x468e625dFD7a1aeb3F4F8B4544a7cA9A8Ad81f00', gas: 250000 })

Maybe this should stay open to track the fix for graphql/dapp?