There is a error that method 'DiscoverAsync' does not have an implementation after upgrating to v2.1.0.0 (OCC-254)

Question

There is a error that method 'DiscoverAsync' does not have an implementation after upgrating to v2.1.0.0 (OCC-254)

effapp opened this issue 2 months ago · comments

Describe the bug

AggregateException: One or more errors occurred. (Method 'DiscoverAsync' in type 'OrchardCore.Commerce.Services.AddressUpdaterShapeTableProvider' from assembly 'OrchardCore.Commerce.ContentFields, Version=2.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.)
System.Threading.Tasks.TaskReplicator.Run(ReplicatableUserAction action, ParallelOptions options, bool stopOnFirstFailure)

TypeLoadException: Method 'DiscoverAsync' in type 'OrchardCore.Commerce.Services.AddressUpdaterShapeTableProvider' from assembly 'OrchardCore.Commerce.ContentFields, Version=2.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
System.Reflection.RuntimeAssembly.GetExportedTypes()

To Reproduce

Steps to reproduce the behavior:

Upgrade to v2.1.0.0
Run project
Throw the error

Screenshots

Jira issue

Sára El-Saig · Answer 1 · Sat May 25 2024 16:14:03 GMT+0800 (China Standard Time)

What version of Orchard Core are you using? IShapeTableProvider.Discover has been removed in favor of DiscoverAsync in the preview versions of Orchard Core. But as of the latest official release (v1.8.3), it is still there along with the default value of DiscoverAsync, meaning that you don't have to implement it in derived methods.

effapp · Answer 2 · Sat May 25 2024 20:26:03 GMT+0800 (China Standard Time)

What version of Orchard Core are you using? IShapeTableProvider.Discover has been removed in favor of DiscoverAsync in the preview versions of Orchard Core. But as of the latest official release (v1.8.3), it is still there along with the default value of DiscoverAsync, meaning that you don't have to implement it in derived methods.

Hi @sarahelsaig,

  Version of Orchard Core is 2.0.0-preview-18218

Sára El-Saig · Answer 3 · Sat May 25 2024 21:37:41 GMT+0800 (China Standard Time)

Yes, that won't work. Regardless of the problem mentioned above, OC 2.0 has several breaking changes, including migration from Newtonsoft.Json to System.Text.Json. This is known to break some existing serialization in OCC and we can't patch it in main until OC 2.0 is released.

The NuGet releases of OrchardCore.Commerce are only meant to be compatible with the latest NuGet releases of OrchardCore. Please downgrade to OC 1.8.3.