Orchestra helm-chart sets 2x "kubernetes.io/ingress.class: nginx"
erkules opened this issue · comments
Erkan Yanar commented
In nginx.yaml we've got
kind: Ingress
metadata:
annotations:
.....
kubernetes.io/ingress.class: nginx
{{ range $key,$value := .Values.network.ingress_annotations }}
{{ $key }}: {{ quote $value }}
{{ end }}
In values.yaml
we've got
ingress_annotations: kubernetes.io/ingress.class: nginx
So the label kubernetes.io/ingress.class: nginx
is set 2x.
Even working with helm it is not a valid yaml and breaks i.e. in fluxcd.
Workaround:
ingress_annotations: kubernetes.io/ingress.class: null
Erkan Yanar commented
I'm not sure if there is a plan to remove one of the labels.
But if so, I would suggest removing it from network.ingress_annotations
. So installations using the workaround don't break.
Marc Boorshtein commented
i removed the labels from the default values.yaml and from the docs. Bump to the latest version and you should be all set.