[Google] PATCH: vmcontrol.py on 64-bit Linux
Fitblip opened this issue · comments
What steps will reproduce the problem?
- Executing default vmcontroly.py on Ubuntu 10.04 64-bit fails because of incorrect check for the "interactive" argument.
What version of the product are you using? On what operating system?
Ubuntu 10.04 64-bit
Please provide any additional information below.
I made the following changes and was able to properly run vmcontrol.py on 64-bit Linux. The script properly controlled the target VM (start, reset to snapshot, stop)
vmcontrol.py diff
340c340
< if not os.name == "nt" and interactive:
---
> if not os.name == "nt":
sulley/pedrpc.py diff (is this related to 64-bitness?)
13,14c13
< #self.NOLINGER = struct.pack('HH', 1, 0)
< self.NOLINGER = struct.pack('ii', 1, 0)
---
> self.NOLINGER = struct.pack('HH', 1, 0)
I'll make a proper git patch for this at some point. Woo-hoo last issue from google! :-D
I need to sit down and work with vmcontrol as well to test this sort of stuff out.