Specify and check maximum badge label length

Question

Specify and check maximum badge label length

opened this issue 6 years ago · comments

Deleted user commented 6 years ago

Currently uses a VCHAR:255 but this will need to be adjusted to the length that fits the game UI.

Deleted user · Answer 1 · Tue Jul 03 2018 07:46:25 GMT+0800 (China Standard Time)

This is now badge_title in table openra_badges.

Deleted user · Answer 2 · Tue Jul 03 2018 08:52:09 GMT+0800 (China Standard Time)

Length should be checked on 'save' before the insert/update query runs, https://github.com/lawando/OpenRAUserAccounts/blob/master/acp/badges_module.php#L79.

Deleted user · Answer 3 · Sun Jul 08 2018 20:39:39 GMT+0800 (China Standard Time)

All badge data will be inserted by the board admin which allows to relinquish input validation. This is in the foreseeable future not within the scope of development so closing for now.