Update to use x/tools/go/analysis

Question

Update to use x/tools/go/analysis

ldez opened this issue 2 years ago · comments

Ludovic Fernandez commented 2 years ago

Hello,

The project still uses the deprecated golang.org/x/tools/go/loader instead of golang.org/x/tools/go/analysis.

https://github.com/golang/tools/blob/587a15310bddfc939d37cfaa8be8ea4c3808c3f1/go/loader/doc.go#L10-L11

Do you plan to migrate to golang.org/x/tools/go/analysis?
Do you need help?

Will Dixon · Answer 1 · Tue Aug 30 2022 05:05:46 GMT+0800 (China Standard Time)

Help is always welcome. I no longer use this tool as the stack I work in daily no longer includes Go :( If I can find the time I will take look into it.

Will Dixon · Answer 2 · Tue Aug 30 2022 16:28:39 GMT+0800 (China Standard Time)

https://github.com/OpenPeeDeeP/depguard/blob/feature/v2/v2/depguard.go started working on it. While digging into it, it was not a backwards compatible change. So I figured out I need to start looking at a V2 variant. Will be defining exactly what that means later this week. Feel free to offer ideas here until I create a V2 issue, milestone, etc.

Will Dixon · Answer 3 · Wed Sep 07 2022 16:08:45 GMT+0800 (China Standard Time)

So I have a working beta v2.0.0-beta.2

go install github.com/OpenPeeDeeP/depguard/v2/cmd/depguard@v2.0.0-beta.2

I have tested on a few repositories. But would like others to try it out to.

Will Dixon · Answer 4 · Sat Mar 25 2023 14:31:15 GMT+0800 (China Standard Time)

I have just released version 2