Giters

OpenMined / syft.js

The official Syft worker for Web and Node, built in Javascript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Plan execution error doesn't reveal actual problem

vvmnnnkv opened this issue · comments

commented

Description

This is snip off from #167 which I think should be fixed first.
If you execute a Plan with an invalid input tensor shape, you'll likely end up with error like
Error: We cannot find function mul in TensorFlow.js, performing a manual lookup..
The real error here is that mul operation failed because of invalid shape, not that mul is not in TFJS.
We need to propagate TFJS error when it occurs during plan execution. Right now it's overwritten with translation error because we don't differentiate between TFJS error and Threepio error.

How to Reproduce

See #167

Expected Behavior

Error wording should reveal the real problem reported by TFJS.

Screenshots

If applicable, add screenshots to help explain your problem.

System Information

  • OS: [e.g. iOS]
  • OS Version: [e.g. 22]
  • Language Version: [e.g. Python 3.7, Node 10.18.1]
  • Package Manager Version: [e.g. Conda 4.6.1, NPM 6.14.1]
  • Browser (if applicable): [e.g. Google Chrome]
  • Browser Version (if applicable): [e.g. 81.0.4044.138]

Additional Context

Add any other context about the problem here.