OpenMined / PySyft

Perform data science on data that remains in someone else's server

Home Page:https://www.openmined.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Resolve MyPy Type Errors

rasswanth-s opened this issue · comments

Description

Currently we only have mypy checks enabled for the serde path because it was temporarily broken and now there are small errors in most files so we can't turn them on in one go.

We need to progressively solve this by enabling some paths one PR at a time and fixing the issues.

- repo: https://github.com/pre-commit/mirrors-mypy
    rev: v1.0.0
    hooks:
      - id: mypy
        name: mypy-syft
        always_run: true
        # files: "^packages/syft/src/syft/serde|^packages/syft/src/syft/util"
        files: "^packages/syft/src/syft/serde"

Since, there are lot of paths, to solve , this issue could be tackled in several PR's
Adding file paths iteratively

To be able to test it ,
Create a virtual Environement for syft development

  1. pip install pre-commit
  2. pre-commit install
  3. pre-commit run --all-files

This should run all the pre commit checks,

Then iteratively add each file, and solve the errors

In progress.