OpenLauncherTeam / openlauncher

Customizable and Open Source Launcher for Android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Metadata structure needs update

IzzySoft opened this issue · comments

commented

the metadata/ folder needs some restructuring if you want it used by F-Droid. While it might have been faster creating a PR then writing up the details here, I don't know what processes you might have tied to the current structure, so…

  • phoneScreenshots and the image files need to go one level deeper inside an images folder
  • one of the icons should be named images/icon.png then (to be used as default/fallback icon)
  • not sure how F-Droid would deal with non-standard image files (all but featureGraphic.png and icon.png directly in the images/ folder) – but in the current location it would definitely break Fastlane processing
  • while on it, maybe the screenshots should be renewed (they're 3 years old), but I cannot tell that.

While this is (hopefully) being processed, I just fixed the current app description which had formatting errors (which were forgotten to be fixed when we updated YAML formatting, so our fault). Once Fastlane structure is fixed, we could switch to that with the next release.

hey izzy,

please feel free to make a pull request to update the hierachy/structure. You know already the correct places, so faster if you do it right away.

from screenshots, not much has changed so we can keep them I'd say.

thx

commented

I gladly do. Just let me know where you wish the non-standard files put to. Suggestion: assets/? That's where those are often found with many projects.

Note to self: do not forget to update the image-links in the Readme 😉

Let you decide for now, just want that icons like for nightly are still there somewhere

commented

Done. And of course you can adjust as needed. Just inside fastlane/metadata/android/ better do not place what doesn't fit the specifications, as that might trip issues with F-Droid picking up the structure properly. Icons for nightly etc. are placed into assets/ for now.

commented

@gsantner the PR is waiting to be merged for 2 months now. Will that happen, so I can cleanup on my end (and drop the fork)?

Oh

I check it when back from holidays.

thx merged

commented

Gladly, and thanks to you! Will you let me know when the next release has been made by you and built by F-Droid? At that point I'd then adjust the YAML file at F-Droid once more (removing summary/description) so your shiny new Fastlane will be used instead.

Hi!
I would also appreciate to have a release made to have a proper build available on f-droid. The recent bugs are very annoying and the respective fixes would be welcomed.
Thank you for the great work!