Giters

OpenIdentityPlatform / OpenAM-JEE-Agents

OpenAM Java EE Policy Agents is an OpenAM add-on component that functions as a Policy Enforcement Point (PEP) for applications deployed on a Java EE-based servlet container or application server. The policy agent protects web-based applications and implements single sign-on (SSO) capabilities for the applications deployed in the container.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Tomcat agent setup does not modify web.xml

lscorcia opened this issue · comments

commented

Hi,
when configuring a new agent on a Tomcat instance the installer modifies the server.xml and the web.xml files under webapps/, but does not add the filter to the global web.xml config file. I think it used to do that automatically, but honestly have no idea when this behavior changed.
I'll try to take a look at the code and see if there's anything obvious in there.

commented

I researched this and it is due to https://github.com/lscorcia/OpenAM-JEE-Agents/blob/9f49c1b9f367498bf93046902382ea0509f16eb6/jee-agents-distribution/jee-agents-distribution-tomcat-v6/src/main/assembly/config/configure.xml#L100-L104

According to the blame, this has been part of the logic since release 3.5 and it is tracked as OPENAM-2726:
https://backstage.forgerock.com/docs/openam-jee-policy-agents/3.5/jee-release-notes/#key-fixes-3_5_0

Unfortunately I have no access to Jira and I cannot understand the reason behind this change. However, I'd say it's not really a problem, so I'll close the issue here with no changes.