Missing closing files

[ryancaicse]

return -1; should be goto quit;? Otherwise, the file test_global.file = fopen(test_global.filename, "w"); is not closed.

odp/example/timer/odp_timer_accuracy.c

Lines 740 to 750 in 2f16a66

 /* Init ODP before calling anything else */ 
 if (odp_init_global(&instance, init_ptr, NULL)) { 
 	printf("Global init failed.\n"); 
 	return -1; 
 } 
  
 /* Init this thread */ 
 if (odp_init_local(instance, ODP_THREAD_WORKER)) { 
 	printf("Local init failed.\n"); 
 	return -1; 
 } 

odp/example/timer/odp_timer_accuracy.c

Lines 720 to 728 in 2f16a66

 if (test_global.opt.output) { 
 	test_global.file = fopen(test_global.filename, "w"); 
 	if (test_global.file == NULL) { 
 		printf("Failed to open file: %s\n", 
 		       test_global.filename); 
 		return -1; 
 	} 
 } 
  

odp/example/timer/odp_timer_accuracy.c

Lines 791 to 814 in 2f16a66

 quit: 
 	if (test_global.file) 
 		fclose(test_global.file); 
  
 	if (test_global.timer_ctx && destroy_timers(&test_global)) 
 		ret = -1; 
  
 	if (test_global.timer_ctx) 
 		free(test_global.timer_ctx); 
  
 	if (test_global.log) 
 		odp_shm_free(test_global.log_shm); 
  
 	if (odp_term_local()) { 
 		printf("Term local failed.\n"); 
 		ret = -1; 
 	} 
  
 	if (odp_term_global(instance)) { 
 		printf("Term global failed.\n"); 
 		ret = -1; 
 	} 
  
 	return ret; 

[Matias Elo]

Thanks for the report. PR #1461 fixes this issue.