Support running mujina-idp on ports other than 8080
mattsheppard opened this issue · comments
It seems like mujina-idp is hard-coded to run on port 8080 - Though I can use --server.port=8081 to have tomcat start on a different port, the metadata produced still refers to port 8080 (Seemingly from https://github.com/OpenConext/Mujina/blob/master/mujina-idp/src/main/java/mujina/idp/MetadataController.java#L76)
It would be convenient, in an integration test scenario, to be able to select a free port at runtime and configure mujina-idp to use that.
I agree with you that this would be a nice feature. Care to write a pull-request?
Sure - I've never touched Spring-Boot before, but that seems to fix the case I was hitting in my environment.
From a quick grep, I don't immediately see other non-test, non-config places where 8080 has been hardcoded, but I've not tested it beyond what I needed.
Oh, wow, I didn't expect it to get released quite so quick - Thanks! :)
It seems that unless application.yml is also changed to have:
idp:
entity_id: http://mock-idp
# base url
base_url: http://localhost:<SET PORT>
it wont work.
You can override it by adding the above to application.yml in the working directory when running java