Dependencies to Mirantis repo
gdubcs opened this issue · comments
Remove dependencies to Mirantis' lensapp repo
- during the build, lens-k8s-proxy is pulled from "https://github.com/Open-Lens/app-k8s-proxy/releases/download/v${args.version}/lens-k8s-proxy-${args.platform}-${args.downloadArch}" (from "packages/ensure-binaries/src/index.ts") which is non-existent
- other paths seem to point to the parent project ("https://github.com/lensapp/artifact-hub-repositories/releases/download/latest/repositories.json")
Suggestion
Either fork those repo or create a Open-Lens/deps repo (or something similar)
Other dependencies found:
- github.com/Open-Lens/app-extensions
- github.com/Open-Lens/app-extension-samples
- github.com/lensapp/artifact-hub-repositories
In fact we just have to repair broken links at this point:
extentions api did not changed from original repo and lens-k8s-proxy can be used as is.
I don't think this is the way to go, we don't know when Mirantis is going to pull the plug on that repo as well.
If they decide to remove it, it will break our builds.
The quick way would be to just host the binary on a "Open-Lens/dependencies" if you really don't want the lens-k8s-proxy repo
Yes we can fork the repo but my point is why to maintain it while it is maintained by the original team ?
I agree Fred, I'm not saying we should maintain it (I don't know go-lang anyway), but merely host the binaries so that our OpenLens build doesn't depend on their repo with hard-coded values.
I think we are quite good on this topic but there are still related issues like broken links in markdown files.
@gdubcs do you see others tasks to do on it ?
I'm afraid so. A project-wide search of "lensapp" in my IDE raised "586 matches across 35 files".
Mostly markdown files though