[Enhancement]: Remove 2-digit length validation on CountrySubdivionCode
arthur-clara opened this issue · comments
Description of Enhancement :
Change the regex pattern to remove the digit length restriction or increase the length to at least 4 digits. (So, allow entries between 2 and 4 digits inclusive: ^[A-Z0-9]{1,5}$
Why is this Needed?
Right now, the countrySubdivisionCode variable is a string that must match regex pattern: ^[A-Z0-9]{1,3}$
This works for US ISO 3166-2 subdivisions (a.k.a. States), but it does not work in countries where the jurisdiction does not match the US ISO 3166-2 codes.
For example, two key startup jurisdictions in the UAE are: "Abu Dhabi Global Market" (ADGM) and "Dubai International Financial Centre" (DIFC). It is impossible to put these jurisdictions into 2 digit format.
Anything else we need to know?
If we want to keep countrySubdivisionCode as 2 digits to validate properly for the US, then we could add an additional optional variable to the Issuer object called "jurisdiction" or something like that.
Change is ok per TWG. Also, action item, look into being able to have mixin validations for regional validation - e.g. we can add the 3166-2 back in where desired for strict us compatibility OR have separate validations for other non-US jurisdictions that might have other requirements.
Hey @arthur-clara, going through some old issues. You think you'll have time to get to this one?
@JSv4 Yeah. I can pick this back up.