Giters

Open-Cap-Table-Coalition / Open-Cap-Format-OCF

Open Cap Format (OCF) - The Open Source Company Capitalization Data Standard. OCF can be used to structure and track the complex data structures necessary to build and maintain accurate capitalization (cap) tables.

Home Page:https://opencaptablecoalition.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Enhancement] - Prevent Duplicate "PartialIds" in $ids

JSv4 opened this issue · comments

commented

@pjohnmeyer just put together a nice PR to let us easily switch our $ids and still pass our tests. In part, it looks to see if the partial $id (the relative schema path in the repo, basically) at the end of the $id can be found.

In our validator.mjs, AJV ensures that you can't have duplicate IDs in files with different paths. That said, it's possible to (erroneously) have two files with the same partialIds at the end (this could happen if someone doesn't know what they're doing or perhaps we have old and new schemas being mixed after the $ids get changed for a a release). Do we need an explicit check to ensure this is not the case?

Originally posted by @JSv4 in #406 (comment)