Fares V2 attributes

Question

Fares V2 attributes

leonardehrenfried opened this issue 2 years ago · comments

Leonard Ehrenfried commented 2 years ago

Fares V2 has been recently added to the mainline GTFS spec.

I'm planning to add support for those new files and properties to this library, so this issue is for tracking the progress.

In a first PR I will focus on the features already in the main spec but I'm planning on also contributing things that are more speculative.

sheldonabrown · Answer 1 · Thu Jun 30 2022 04:49:52 GMT+0800 (China Standard Time)

Thanks! I see lots of activity still -- should this be considered ready or should I wait a little longer?

Sheldon

Leonard Ehrenfried · Answer 2 · Thu Jun 30 2022 05:13:22 GMT+0800 (China Standard Time)

I thought it was ready to review but after doing the actual import into OTP I noticed a few more problems. Maybe hold off reviewing for a few more days.

If you already notice something that looks odd, you can already tell me and I will fix it.

Leonard Ehrenfried · Answer 3 · Thu Jun 30 2022 14:06:55 GMT+0800 (China Standard Time)

One question: I would like to also add files and columns that aren't part of the spec yet. Would you like all of them in a single request or separate ones?

sheldonabrown · Answer 4 · Tue Jul 12 2022 02:19:21 GMT+0800 (China Standard Time)

Sorry, I missed the question. A single request is fine, no need to split it out.

Leonard Ehrenfried · Answer 5 · Tue Jul 12 2022 05:44:37 GMT+0800 (China Standard Time)

Ok, then the PR is ready to review: #197

Leonard Ehrenfried · Answer 6 · Tue Dec 13 2022 16:52:30 GMT+0800 (China Standard Time)

This has been implemented for a while.