AgencyId in SubsectionTripTransformStrategy is not preserved?

[Hannes]

Summary:

I suspect that this line

onebusaway-gtfs-modules/onebusaway-gtfs-transformer/src/main/java/org/onebusaway/gtfs_transformer/updates/SubsectionTripTransformStrategy.java

Line 106 in fd87efe

 newTrip.setId(new AgencyAndId("1", id)); 

should actually be like this line

onebusaway-gtfs-modules/onebusaway-gtfs-transformer/src/main/java/org/onebusaway/gtfs_transformer/updates/TrimTripTransformStrategy.java

Line 93 in fd87efe

 newTrip.setId(new AgencyAndId(trip.getId().getAgencyId(), id)); 

because both methods are trimming trips somehow (still need to grasp their differences, though).

Steps to reproduce:

I have not run anything yet, I'm reading and trying to understand the code's functionality.

Expected behavior:

I expect the original AgencyId to persist when transforming a trip, or, if this is not reasonable, to use a configurable AgencyId.

Observed behavior:

The line in SubsectionTripTransformStrategy introduces a new constant AgencyId "1" and does not reuse the AgencyId of the original trip.

Platform:

• onebusaway-gtfs-modules: 1.3.101-SNAPSHOT

Thank you for your work at these helpful modules.