OneBusAway / onebusaway-gtfs-modules

Summary:

When providing an output path with a capital ".ZIP" extension, instead of lowercase, onebusaway-gtfs-transformer-cli.jar treats the output as a directory instead of a zip file.

Steps to reproduce:

java -jar onebusaway-gtfs-transformer-cli.jar --transform=modifications.txt source-gtfs.zip target-gtfs.ZIP

Expected behavior:

Creates an output zip file with gtfs

Observed behavior:

Creates an output directory called target-gtfs.ZIP

Platform:

macOS 10.14.6
openjdk 12.0.2 2019-07-16
OpenJDK Runtime Environment (build 12.0.2+10)
OpenJDK 64-Bit Server VM (build 12.0.2+10, mixed mode, sharing)
onebusaway-gtfs-transformer-cli-1.3.4-20150503.062227-12.jar

From skimming, the issue seems to be because of this line:

onebusaway-gtfs-modules/onebusaway-gtfs-transformer/src/main/java/org/onebusaway/gtfs_transformer/GtfsTransformer.java

Line 149 in 657d831

&& !_outputDirectory.getName().endsWith(".zip"))

Output mistaken as directory if extension is ".ZIP"