Add CancellationToken support on async calls

Question

Add CancellationToken support on async calls

brianfeucht opened this issue 4 years ago · comments

It is considered a best practice to provide a CancellationToken to allow for the cancellation of tasks.

It doesn't appear that any of the async code in this library has any support for passing in a CancellationToken. This means if a query end up being long running there is no way for the caller to abort a request. This can cause problems for things like Windows Services where the expectation is to respond quickly to shutdown requests.

Yawar Jamal · Answer 1 · Mon Oct 05 2020 04:05:53 GMT+0800 (China Standard Time)

Hi @droyad, I have been lately using this client at work and have noticed the absence of CancellationToken can I take a stab at the following issue?

Matt Richardson · Answer 2 · Mon Oct 05 2020 12:10:07 GMT+0800 (China Standard Time)

Hi @yj7o5 - sure, go for it! PRs definitely appreciated 👍

Yawar Jamal · Answer 3 · Tue Oct 06 2020 10:45:50 GMT+0800 (China Standard Time)

Thanks guys, feel free to assign it to me and I'll get the PR in a day or two. :)

Yawar Jamal · Answer 4 · Sat Oct 10 2020 14:55:07 GMT+0800 (China Standard Time)

@matt-richardson PR submitted for your review! Thanks.