[1.10.0rc1] No warning when overwriting a file on upload
larp-welt opened this issue · comments
The problem
When I upload a gcode file with the same name as an existing one, no window message pops up to warn me and to ask me what to do.
Did the issue persist even in safe mode?
Yes, it did persist
If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)
No response
Version of OctoPrint
1.10.0rc1
Operating system running OctoPrint
OctoPi
Printer model & used firmware incl. version
Pursa Mk3S+
Browser and version of browser, operating system running browser
Version 120.0.6099.199 (Offizieller Build) for TUXEDO Computers GmbH (64-Bit) running on Tuxedo
Checklist of files to include below
- Systeminfo Bundle (always include!)
- Contents of the JavaScript browser console (always include in cases of issues with the user interface)
- Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
- GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)
Additional information & file uploads
Kazam_screencast_00000.mp4
This seems to be reproducible inside a folder. Uploading to the root folder I do get the overwrite/rename prompt as expected.
Along with that, if a file exists in the root uploads folder, attempting to upload the same named file in a folder shows the overwrite/rename prompt.
That was an error crept in through the PR that added the file details and which I overlooked during review, sh*t happens ^^
Now fixed for 1.10.0rc2, thanks for reporting!
1.10.0rc2 has just been released 👍