[1.10.0rc1] drag and drop upload not working

Question

[1.10.0rc1] drag and drop upload not working

jneilliii opened this issue 5 months ago · comments

jneilliii commented 5 months ago

The problem

When dragging a gcode file onto the UI the overlay doesn't show and upload never happens.

Did the issue persist even in safe mode?

Yes, it did persist

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

No response

Version of OctoPrint

1.10.0rc1

Operating system running OctoPrint

OctoPi 1.1.0 (nightly bookworm build) and OctoPi 0.18.0 (build 2022.10.18.093204)

Printer model & used firmware incl. version

Virtual Printer

Browser and version of browser, operating system running browser

Google Chrome Version 121.0.6167.87 (Official Build) (64-bit)

Checklist of files to include below

Systeminfo Bundle (always include!)
Contents of the JavaScript browser console (always include in cases of issues with the user interface)
Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

octoprint-systeminfo-20240131192605.zip

192.168.126.109-1706747235133.log

chrome_mFXOBz3L1h.mp4

larp-welt · Answer 1 · Fri Feb 02 2024 07:39:08 GMT+0800 (China Standard Time)

I have the same problem...

octoprint-systeminfo-20240201233649.zip

Bundles:

octoprint-systeminfo-20240201233649.zip

edited by @github-actions to add bundle viewer links

Gina Häußge · Answer 2 · Fri Feb 02 2024 17:14:25 GMT+0800 (China Standard Time)

I'll look at this on Monday 👍

jaymcd · Answer 3 · Sun Feb 04 2024 01:00:09 GMT+0800 (China Standard Time)

Same issue here

jneilliii · Answer 4 · Sun Feb 04 2024 02:29:23 GMT+0800 (China Standard Time)

I think this may be a race condition with settings load. My previous PR that enabled the option in settings was definitely working, but now seems that the feature_enableDragDropUpload observable is detected as undefined on serverConnect when the drag and drop binding is taking place.

jneilliii · Answer 5 · Sun Feb 04 2024 02:32:42 GMT+0800 (China Standard Time)

possible solution might be to do the self._enableDragNDrop(true); in an observable subscription to feature_enableDragDropUpload, and pass along the boolean from new value?

jaymcd · Answer 6 · Sun Feb 04 2024 05:01:56 GMT+0800 (China Standard Time)

In my case, will test if it had anything to do with UI customizer as that seems to be acting weird well. Many settings don't take.JayOn Feb 3, 2024, at 12:32 PM, jneilliii ***@***.***> wrote: possible solution might be to do the self._enableDragNDrop(true); in an observable subscription to feature_enableDragDropUpload, and pass along the boolean from new value? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

jneilliii · Answer 7 · Sun Feb 04 2024 08:23:02 GMT+0800 (China Standard Time)

It doesn't make a difference with UI Customizer or not. The issue exists in safe mode, which has no plugins running.

Gina Häußge · Answer 8 · Mon Feb 05 2024 21:11:27 GMT+0800 (China Standard Time)

Yeah, that definitely looks like a race condition. The thing is, when the server gets connected, the settings aren't yet retrieved. The fact this ever worked was probably rather the race condition 😅 Or the performance optimizations made a change.

In any cases, fixed, see the commit above.

Gina Häußge · Answer 9 · Mon Feb 12 2024 21:30:16 GMT+0800 (China Standard Time)

1.10.0rc2 has just been released 👍