Compile error

Question

Compile error

SOLcoelle opened this issue 2 years ago · comments

Compilation breaks with org.owasp.esapi:esapi:2.5.1.0 because org.owasp.encoder.esapi.ESAPIEncoder.Impl does not implement the new methods

org.owasp.encoder.esapi.ESAPIEncoder.Impl#decodeFromJSON
org.owasp.encoder.esapi.ESAPIEncoder.Impl#encodeForJSON

which were introduced with the 2.5.1.0.

Solution (?):

Set a fix dependency on the previous version of org.owasp.esapi:esapi
Implement and test the missing interface functions
Update the dependency

Kevin W. Wall · Answer 1 · Thu Dec 01 2022 06:18:52 GMT+0800 (China Standard Time)

@Manicode- I can submit a PR to fix this for you if you want, but I am away on business with only a company laptop, so I likely won't be able to address it until probably Saturday.

On Wed, Nov 30, 2022, 9:40 AM SOLcoelle ***@***.***> wrote: Compilation breaks with org.owasp.esapi:esapi:2.5.1.0 because org.owasp.encoder.esapi.ESAPIEncoder.Impl does not implement the new methods - org.owasp.encoder.esapi.ESAPIEncoder.Impl#decodeFromJSON - org.owasp.encoder.esapi.ESAPIEncoder.Impl#encodeForJSON which were introduced with the 2.5.1.0. Solution (?): - Set a fix dependency on the previous version of org.owasp.esapi:esapi - Implement and test the missing interface functions - Update the dependency — Reply to this email directly, view it on GitHub <#63>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6PG64JDKDWFGEY67JMXLWK5RNVANCNFSM6AAAAAASPWTYMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-kevin

Kushagra Nigam · Answer 2 · Thu Nov 23 2023 00:01:07 GMT+0800 (China Standard Time)

Hi,
What is the latest on this issue?

Kevin W. Wall · Answer 3 · Thu Nov 23 2023 00:58:39 GMT+0800 (China Standard Time)

@TheMarvelFan - I never heard back from @manicode (but perhaps that's because he's not using GH handle @jmanico) so I never submitted a PR. But given that I and on the verge of releasing a new ESAPI release (2.5.3.0) in the next day or two, it seems prudent to wait until that is released.

@jmanico - I think this is related to the esapi-thunk portion of the OWASP Java Encoder project. I think the fix should be pretty easy.

Kushagra Nigam · Answer 4 · Thu Nov 23 2023 01:03:51 GMT+0800 (China Standard Time)

Alright I will check back after 2 days, and open a PR asap.

Jim Manico · Answer 5 · Thu Nov 23 2023 06:46:41 GMT+0800 (China Standard Time)

Kevin, I have not touched this in a while. Would you care to help?

Kevin W. Wall · Answer 6 · Thu Nov 23 2023 08:03:26 GMT+0800 (China Standard Time)

Sure. I'll create a PR for it a soon as the new ESAPI 2.5.3.0 release is available from Maven Central. Should have that done by this Friday at the latest.

…

-kevin

On Wed, Nov 22, 2023, 5:46 PM Jim Manico ***@***.***> wrote: Kevin, I have not touched this in a while. Would you care to help? — Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6PGZUDR2RRWN464W3QNTYFZ6F3AVCNFSM6AAAAAASPWTYM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTGU4TOOJXGA> . You are receiving this because you commented.Message ID: ***@***.***>