Giters

OT-CONTAINER-KIT / redis-operator

A golang based redis operator that will make/oversee Redis standalone/cluster/replication/sentinel mode setup on top of the Kubernetes.

Home Page:https://ot-redis-operator.netlify.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Creating redis cluster by executing cluster creation commands" log line is redundand and misleading

egorksv opened this issue · comments

commented

Source code link:

redis-operator/controllers/rediscluster_controller.go

Line 194 in 3e6fcb9

reqLogger.Info("Creating redis cluster by executing cluster creation commands", "Leaders.Ready", strconv.Itoa(int(redisLeaderInfo.Status.ReadyReplicas)), "Followers.Ready", strconv.Itoa(int(redisFollowerInfo.Status.ReadyReplicas)))

Operator issues "Creating redis cluster by executing cluster creation commands" every reconciliation cycle (i.e. every 10 seconds).

This is extremely misleading as it creates perception that cluster is NOT created/reconciled yet and extra actions are still necessary, whereas in reality the cluster has been ready for some time.

It also does not add any value during actual cluster configuration phase as it's not directly linked to any operations

commented

Yes, we can put the log clause into the

if nc := k8sutils.CheckRedisNodeCount