Black-oil Polymer Module Compares Iterators into Different Containers

Question

bska opened this issue 5 years ago · comments

const auto iterTable = skprwatTables_.find(tableNumber);
if (iterTable != plymwinjTables_.end()) {

Here the iterTable iterator is compared to the end() of a container different from the one used to create it. That's undefined behaviour.

Kai Bao · Answer 1 · Mon Mar 25 2019 17:24:00 GMT+0800 (China Standard Time)

Thanks for spotting it. I will create a fix of it.

Kai Bao · Answer 2 · Mon Mar 25 2019 17:31:05 GMT+0800 (China Standard Time)

closed by #497.

Bård Skaflestad · Answer 3 · Mon Mar 25 2019 17:35:10 GMT+0800 (China Standard Time)

Thanks for spotting it.

I didn't. I just ran OPM-Simulator's compareECLFiles_flow+2D_POLYMER_INJECTIVITY regression test using libstdc++'s debug mode as part of some other work.