OFFLINE-GmbH / oc-gdpr-plugin

October CMS plugin to make websites GDPR and ePrivacy compliant

Home Page:https://octobercms.com/plugin/offline-gdpr

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CookieBanner not working

dariopetraroia opened this issue · comments

Hy, I have a problem with the cookie banner, it appears again after close and reopen the browser on Chrome Mobile and Firefox Mobile.
The cookieBanner.hide variable is always false.

UPDATE: The issue happens also on desktop. This is how to reproduce it:

The problem is when you come to the site over a search engine...

https://www.google.com/search?q=offline+gmbh

then click on the first result and visit the website https://offline.ch/
Accept cookie

Search website again https://www.google.com/search?q=offline+gmbh

click on the website, and the banner comes again.

SECOND option to reproduce it:

go to https://offline.ch/ accept cookies and refresh site, banner is showing again.

Hy, i fixed this by commenting: // self::SAME_SITE // sameSite

    return Cookie::queue(
        'gdpr_cookie_consent',
        $value->toJson(),
        $this->expiry,          // expire
        '/',                    // path
        null,                   // domain
        $this->isHttps(),       // secure
        true,                   // httpOnly
        false,                  // raw
        // self::SAME_SITE         // sameSite
    );

Or setting SameSite to lax dimti@98be902

Thank you, guys. This is fixed in 83a1574