Usage of ingress controller level wildcard certificat

Question

Usage of ingress controller level wildcard certificat

jfv-opensource opened this issue 7 months ago · comments

Dear,

the current version of the helm force to create a specific secret in the ocs inventory namespace to store the http certificate. It may be a good idea to allow usage of the ingress controller level certificate. In the common helms, a secret name field is present but if not filled, secret is not created and ingress not references it.

Many thanks,

BR,
jfv

PS: I can contribute

jfv-opensource commented 7 months ago

MR: #6

Gilles Dubois · Answer 1 · Wed Dec 13 2023 17:41:17 GMT+0800 (China Standard Time)

Hello,

Your idea is really interesting and is a closer fit to the good practices on helm charts.
Its something we definitely missed out when pushing the first release.

If you want to contribute, we will be glad to review your pull request and welcome you as a contributor :)

Regards,
Gilles DUBOIS.

jfv-opensource · Answer 2 · Thu Dec 14 2023 16:02:36 GMT+0800 (China Standard Time)

I'm on it, Will propose mr soon.

Gilles Dubois · Answer 3 · Thu Dec 14 2023 16:29:52 GMT+0800 (China Standard Time)

You're welcome ! I remain available if you have any questions :)

jfv-opensource · Answer 4 · Wed Jan 17 2024 15:06:56 GMT+0800 (China Standard Time)

The change is commited

Gilles Dubois · Answer 5 · Wed Jan 17 2024 16:19:24 GMT+0800 (China Standard Time)

I'm closing this issue, fixed with #6