enforcing @action to be on a separate line

[David Tang]

This is what's happening for me. The one method fails linting as expected, but as soon as I define a body like in method two, linting passes when I expect it to fail. This is all of the code:

import Component from '@glimmer/component';
import { action } from '@ember/object';

export default class Foo extends Component {
  @action one() {}

  @action two() {
    return 2;
  }
}

[NullVoxPopuli]

👋 Hello!!

what's your lint config look like?

[NullVoxPopuli]

Reason I ask is because I added this test:

and it passed 🤔

[David Tang]

hey 👋!

Here is my config:

{
  "decorator-position/decorator-position": [
    "error",
    {
      "properties": "prefer-inline",
      "methods": "above"
    }
  ]
}

With the above, shouldn't it fail if @action is inline?

[NullVoxPopuli]

yeah, I'd expect two errors, one for each action.

[NullVoxPopuli]

if you run eslint . --fix, what happens?

[David Tang]

eslint . --fix only fixes the first one which is failing. I created a reproduction repo here: https://github.com/skaterdav85/decorator-linting-reproduction

[NullVoxPopuli]

Thanks, I've copied that into the test suite here: #475

dunno when I'll have time to fix -- but thanks for reporting!!!