SourceLink configured incorrectly for NuGet.*.dll binaries shipping with VS
KirillOsenkov opened this issue · comments
This is a continuation of #12745 since I can't reactivate that issue.
NuGet Product Used
Visual Studio Package Management UI
Product Version
17.10.4
Worked before?
it worked in some versions
Impact
It's more difficult to complete my work
Repro Steps & Context
For Visual Studio 17.10.4, the NuGet binaries shipping in C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet
aren't working well with SourceLink.
For example, if you consider NuGet.Commands.dll, the pdb Guid is 69abc799-5795-4e85-9da6-fcc063962cae
, and the Pdb path is D:\a\_work\1\s\artifacts\NuGet.Commands\obj\release\net472\NuGet.Commands.pdb
.
I am able to download the pdb from symweb.
dotnet tool update -g pdb
pdb NuGet.Commands.dll NuGet.Commands.pdb
C:\temp\pdb\NuGet.Commands.dll
Reproducible
Guid: 69abc799-5795-4e85-9da6-fcc063962cae
Age: 1
Pdb path: D:\a\_work\1\s\artifacts\NuGet.Commands\obj\release\net472\NuGet.Commands.pdb
Stamp: F26834C1
Found NuGet.Commands.pdb: Match
C:\temp\pdb\NuGet.Commands.pdb: Native pdb: Microsoft C/C++ MSF 7.00
SourceLink:
{"documents":{"D:\\a\\_work\\1\\s\\submodules\\NuGet.Build.Localization\\*":"https://raw.githubusercontent.com/NuGet/NuGet.Build.Localization/4cd83dc7d7e366bf85c68b6612ff048466435af6/*"}}
Other document paths are stored in a format such as D:\a\_work\1\s\src\NuGet.Core\NuGet.Commands\SignCommand\ISignCommandRunner.cs
which can't be used to download the sources from GitHub via SourceLink.
To be able to properly debug into NuGet binaries shipping with VS it is important to have SourceLink configured properly, as well as ideally consider portable Pdbs.
Verbose Logs
No response
Issue is missing Type label, remember to add a Type label