Giters

NoriginMedia / Norigin-Spatial-Navigation

React Hooks based Spatial Navigation (Key & Remote Control Navigation) / Web Browsers, Smart TVs and Connected TVs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support for RTL

jeev1989 opened this issue · comments

commented

Describe the bug
On RTL looks like the initial focus on the swimlane is not being picked properly, also key navigation which needs to be reveresed.

To Reproduce
Steps to reproduce the behavior:

  1. Load the demo app, change the body dir to rtl
  2. navigate left from the menu to bring the focus on the swimlanes
  3. Observe the current focused element, this is not the expected element

Expected behavior
Focused element is the 7th item(sn:focusable-item-28) in the swimlane, where as it should have been the first.

Screenshots
Screenshot 2023-07-31 at 5 47 42 PM

Additional context
Is RTL support expected/planned for this library? It would be a good feature if it supports RTL on the fly.

commented

@asgvard @zemlanin @eigil @hans00 : Can anybody please let me know if you guys are aware of such an issue?

commented

There are issues on RTL, is there a way to fix it?

commented

Add support for RTL #96 seems to be working as expected as per the issue reported by me.
Kindly request @asgvard @zemlanin @eigil @hans00 to checkout the PR and update if changes are good.

commented

Status Update:

The pull request Add support for RTL has been approved. It will be incorporated into the upcoming release, effectively addressing the associated issue.

commented
commented

Thanks alot guys..