NoriginMedia / Norigin-Spatial-Navigation

React Hooks based Spatial Navigation (Key & Remote Control Navigation) / Web Browsers, Smart TVs and Connected TVs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove enter button

ChocolateLoverRaj opened this issue · comments

Is your feature request related to a problem? Please describe.
I don't think the enter button is related to navigation. Like #56 (comment), a keydown listener that checks if the element is focused can be used instead of an enter press.

Describe the solution you'd like
Remove enter key from key map, and remove other inputs related to enter button.

Describe alternatives you've considered
N/A

Additional context
Related to #56 (comment)

commented

Hello @ChocolateLoverRaj.

Thanks for sharing your opinion.

From our viewpoint we have seen no need to explicitly remove this, as it's a less verbose interface to achieve the functionality of handling the enter-presses of the focusable elements, with basically no downsides.

If you do however wish to not use this functionality then it is a simple matter of not defining the onEnterPress callback -
In which case you can add your own listeners to achieve your intended functionality.

Best of luck to you!