Update `node-dup2`
piranna opened this issue · comments
node-dup2 code is fairly old and needs to be updated, if someone accepts the challenge please tell (it's a small module, so could be useful is someone want to learn to build compiled modules), if not I'll try to update it myself. Seems it could be the missing thing to make nsh to work, similarly as how I did in P9sh :-)
Another option would be to add it to our own module node-src-unistd... :-P
Is it ok if I update it to Node Addon Api (N-API). If yes assign me the Task and i'll update it as soon as i'm home.
Assigned ;-) Now that nsh correctly works this is not needed anymore, but it would be good to have this module updated, and probably would be good for learning tasks :-)
Regarding node-src-unistd, yes, this is being actively used ;-)
Module is updated with everything and it works flawlessly!
The only thing to do is writing tests.
If you want i can port node-src-unistd to napi and add type checks