NoHomey / material-ui-number-input

The <TextField type="number" /> that user really expects.

Home Page:http://nohomey.github.io/material-ui-number-input

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix all bugs introduced with 5.0.13 and 5.0.12

NoHomey opened this issue · comments

There have been several bugs introduced with 5.0.13 and 5.0.12 releases:

Both 5.0.12 5.0.13 and tried to fix a bug where onError, onValid and onRequestValue are not called when either of there props: min, max, required and strategy changes. But instead they just introduced more bugs which let to onError to not be called on time and old props to be used.

The fix of these bugs is to change all methods that reference this.props to accept props: NumberInputProps argument passed to them which means that those methods that don't reference this other than for props should be made static.

#3 fixes this.