Njmcq / iCloud-Control

User-controlled selective sync for iCloud Drive

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Various issues affecting macOS 10.13

Njmcq opened this issue · comments

Notification permissions aren't requested by the system, so an entry doesn't appear in the Notifications panel in System Preferences and notifications don't work as expected.

Currently testing potential solutions.

Looks like notification permissions are somewhat tricky to implement. I've removed the 10.13 notifications code and simply put up an alert that informs the user that notifications aren't compatible with 10.13. It's a pain to have to take the easy way out, but I'm just too boggled by it. Documentation on the topic is tough to come by, now that UNUserNotificationCenter is the main framework. If anyone happens to know how to do it, a PR would be great!

Also found another bug which has existed on High Sierra since 1.2.0. Looks like the toolbar extension icon was overlooked when it was adjusted for Mojave's Dark Mode. High Sierra didn't know what to do with light and dark icons, so it would revert to using neither. I've managed to fix that by using the original black icon under Any Appearance.

And finally, it turns out that the Help button and menu bar item wouldn't open the HelpViewController properly on 10.13. It was tricky to build a solution for this issue, so I've just reverted to opening the README in the default browser on all systems. The actual HelpViewController has been removed, to be published along with the rest of the aforementioned patches in release 1.7.1.

Reopened this as the fix for the issues will take longer to release than I initially anticipated.

Migrated all fixes from the previously-planned 1.7.1 to a new 1.8.0 release, which will introduce new features and improvements across the board. Should release within the next couple of weeks.

1.8.0 fixes most of the 10.13 issues. However, notifications remain unavailable under further notice.