Make GitHub notify when an eval error has occoured?
doronbehar opened this issue · comments
Rather often, when you rename a package attribute or alike, another package you were not aware of has used the attribute name you deleted, and you forgot to change it accordingly.
It'd be nice if ofborg had sent via GitHub an email notifying of the eval failure - just like the EditorConfig job for example. This is helpful in slow evaluation which happen in e.g treewide: like PRs.
You do get a red X in the https://github.com/pulls view when CI fails. Sending messages every time eval fails would cause a storm everytime master fails eval.
You do get a red X in the github.com/pulls view when CI fails. Sending messages every time eval fails would cause a storm everytime master fails eval.
Correct, but I don't think it is bad. Eval errors on master happen rarely, and when they do, I think it wouldn't hurt to notify many people about it, as it is a severe mistake. Also, even if the error is not due to merges you personally performed, it will also give you the hint to comment @ofborg eval to retrigger evaluation after the eval error is fixed.
Doesn't this work?
@pbsds this seems worth checking, but I don't understand how did you get to that interface? I also wonder, why is EditorConfig's workflow notifying me upon emails and ofborg doesn't? The interface you screenshot doesn't look like it has different settings for the above 2 workflows...
It may be because the editor config checks run in a github action runner, while the ofborg CI checkmarks are set using some other API by the ofborg runners.