Always evaluate with `config.allowAliases = false` to avoid deprecation warning errors
roberth opened this issue · comments
Since #250, we've been checking that Nixpkgs doesn't depend on aliases.
In NixOS/nixpkgs#134230 I've had to revert deprecation warnings in order to let ofborg evaluate cleanly.
If we apply allowAliases = false
to all evaluations, we will be able to provide helpful deprecation warnings without causing ofborg to fail.
It will also save an evaluation, because the separate check from #250 will be implicit in the other evals.
Bump.
This is annoying for nixpkgs-review users because ofborg lists aliases in ^.^!
which don't work if you have aliases locally disabled and break the tool.
i had to nixpkgs-review pr 166605 --eval local
otherwise i got this error
130 artturin@nixos ~ % review 166605
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs staging:refs/nixpkgs-review/0 pull/166605/head:refs/nixpkgs-review/1
$ git worktree add /home/artturin/.cache/nixpkgs-review/pr-166605-3/nixpkgs 8459123046dbdb9f03145310c5e36ce6195a7151
Preparing worktree (detached HEAD 8459123046d)
Updating files: 100% (30114/30114), done.
HEAD is now at 8459123046d Merge pull request #166715 from siraben/social-auth-eval-fix
$ git merge --no-commit --no-ff 4f2f6cb71e171016cea0f86f4ed6f36976fb4406
Automatic merge went well; stopped before committing as requested
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/artturin/.cache/nixpkgs-review/pr-166605-3/build.nix
error: attribute 'python_rsvg' missing
at /home/artturin/.cache/nixpkgs-review/pr-166605-3/build.nix:3567:9:
3566| gnome2."gnome_python"
3567| gnome2."python_rsvg"
| ^
3568| gnome2."gnome_vfs"
(use '--show-trace' to show detailed location information)
created
NixOS/nixpkgs#166790