Add inline comments for missing maintainer, homepage, changelog, license fields

Question

Add inline comments for missing maintainer, homepage, changelog, license fields

davidak opened this issue 5 years ago · comments

davidak commented 5 years ago

Just a reminder that:

Ofborg could and should send inline comments suggesting filling out maintainer, homepage, change log, license fields.

Source: NixOS/nixpkgs#60371 (comment)

Timo Kaufmann · Answer 1 · Sat Nov 09 2019 19:13:40 GMT+0800 (China Standard Time)

Also maybe nice would be to check if the website is actually available. And if it is, it would be cool to assure that it is included in the internet archive. Though I'm not entirely sure what their stance on automated saving is.

davidak · Answer 2 · Sun Nov 10 2019 03:24:11 GMT+0800 (China Standard Time)

@timokau problems with the website are also detected by repology. Maybe that's enough?

Timo Kaufmann · Answer 3 · Sun Nov 10 2019 07:37:18 GMT+0800 (China Standard Time)

It would certainly be nicer if ofBorg could already detect it in the offending PR. For example if changelog = https://some-webpage.com/${version} it would immediately notice if there was no changelog for ${version} and the PR author could check if the changelog moved.