NixOS / nixos-hardware

A collection of NixOS modules covering hardware quirks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

pinebook pro: update known issue info

xeniarose opened this issue · comments

The current (readme for pinebook pro)[https://github.com/NixOS/nixos-hardware/blob/master/pine64/pinebook-pro/README.md] mentions a known issue with "rockchipdrm and efifb"

It looks like this was fixed in Tow-Boot/Tow-Boot#8, in kernel 5.14. I spent a bit of time working on booting the UEFI installer image on pinebook pro with the additional efifb=off option only to find out it is currently unnecessary. Should the section on it be removed from the README, or at least updated to state that 5.14+ resolves it?

I think it could be removed entirely. There's been three kernel LTSes since.

should i submit a PR?

Sure, the nixos-hardware repo is for users to update with the current state of things :)