NixOS / nixos-artwork

Nix related artwork

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Square logo?

ryantm opened this issue · comments

I was surprised that the logo is very close to square but it is not square. Is this intentional? Would a logo revision that makes it square be welcome?

Can a regular hexagon fit snugly against all sides of a square? Maths says no! :) (At least, not without rotating it a a weird angle.)

Though, what do you mean, you want to see a logo file where the drawing area is square, with the logo appropriately centered?

What would be the use of such file? (It would help to know how it'd be used, I guess)

Yes, I was looking for the drawing area to be square.

I am trying to fix this warning message that Discourse keeps warning us about:
discourse_icon_warning

It is asking for a 512x512 px logo.

Well, I went ahead and extended the canvas in GIMP and uploaded it. It's weird that the icon directory Makefile generates a folder called 512x512, but the file inside is not that exact dimensions. Is that typical with icons?

Oh, I would assume it's not "right" to have a 512x512 (or 𝒙×𝒙) directory with non-squared images. Keep this open, with actionable task: make the Makefile generate square files.

I believe this is how the png images are generated for use on an installed NixOS system, good thing that apparently nothing fails when using non-square images here.

It does seem like the logo being non-square causes it to be unevenly rescaled on GNOME:
image
This is because the .svg is directly copied over into hicolor/scalable/apps/ alongside the converted .png versions. Perhaps we should consider either making the SVG square or converting it into a square one in icons/Makefile.

Sorry for unearthing this issue after three years by the way 😅

Don't be sorry, you're right. This isn't looking correct :)

I guess the quickest solution at least for the svg and png would be adding a bunch of transparent bars above and below to mock some square-ish dimensions.

A special logo-squared.png should be the best fit for not breaking systems that require the file dimensions being equal to the content's bounding box.