Event subscription naming does not use fully-qualified handler type name

[Eddie Stanley]

The implementation of PathFactory::SubscriptionNameFor() currently uses handlerType.Name. It should use .FullName because otherwise an event subscription will get lost if there are two handlers for the same event type which happen to be named the same (but under different namespaces).

[Drew Freyling]

@flakey-bit is this a problem for both v2 and v3?

[Eddie Stanley]

Yes it affects both versions.

[Drew Freyling]

Can you add this to the V2 repo as well?

…

On Wed., 1 Nov. 2017, 12:07 pm Eddie Stanley, ***@***.***> wrote: Yes it affects both versions. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#274 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABF8DVXzA0YcgCLrntmDHSksKCBcfBaBks5sx9J5gaJpZM4QCRt4> .

[Damian Maclennan]

From memory this is because of queue name length restrictions in ASB. I'd have to go double check that though.
We could throw on registration if you had two handlers with the same name for the same message though?

[Eddie Stanley]

The code already (currently) handles names being too long by hashing the name and adding the hash as a suffix. So it should be a simple fix.

[Damian Maclennan]

Cool, want to have a crack at it?

[Eddie Stanley]

I'll take a look if I get a spare moment :)

[Drew Freyling]

@flakey-bit any progress?

[Eddie Stanley]

Apologies for leading you on - I don't think I'll realistically ever have time to look at this.