No change while bisecting, current was empty somehow

Question

No change while bisecting, current was empty somehow

Nilstrieb opened this issue 2 years ago · comments

  213349ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no
  215275ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no
  217217ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no
  222527ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: yes
  222527ms  INFO cargo_minimize::processor src/query/mod.rs: After privatize: no changes
thread 'main' panicked at 'internal error: entered unreachable code: No change while bisecting, current was empty somehow: {AstPath([])}', src/processor/checker.rs:173:17

while running the privatize pass on pi_ecs@0.1.0

Nilstrieb · Answer 1 · Mon Jan 23 2023 15:54:15 GMT+0800 (China Standard Time)

Rerunning cargo-minimize fixes it

Nilstrieb · Answer 2 · Mon Jan 23 2023 16:08:15 GMT+0800 (China Standard Time)

fa0b302 probably helps but what is really needed is a proper way to do this tracking..

I think I should probably start with a HasName trait implemented for all the syn structs.
And then using a bunch of macros define my own visitor trait that tracks this properly