Giters

NikolaiMagnussen / fork-execv-worm

Simple distributed Rust worm using fork-exec to detach from parent and hide

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Smiley Face should follow Smiley Face convention

evenstensberg opened this issue · comments

commented

Summary

At this line I found a very disturbing use of smileys. As a smileyface patriot, I'm quite obsessed with smileys and this implementation breaks my heart. The code simply doesn't feel rite in my eyes without proper smileys, and also Licensing might be an issue. I highly suggest that you replace the smiley so that people won't get offended when reading the source code. This article explains smileyfaces in depth along with this research paper.

Behaviour:

Stacktrace Sleeping done - exiting now! :)

Expected

Stacktrace Sleeping done - exiting now! :-)

I hope you prioritize this issue, as it's breaking my current implementation. God Bless :)

commented

Thank you for the friendly reminder. I will try and resolve this issue at once.

commented

Thanks for fixing, our build is now passing 🎉