Mapset Verifier checks
NiceAesth opened this issue · comments
This table is copied from ppy#12091 (comment). Keeping track of an updated version.
Checks from Kyazero/MVAdditions are also intended to be ported, with permission given here.
Related links:
https://github.com/Naxesss/MapsetChecks/tree/master/Checks
https://github.com/Naxesss/MapsetVerifierFramework/tree/master/objects
https://github.com/KyaZero/MVAdditions/tree/main/Checks
Status
✔️ Done
🟡 Done, but not merged
❌ Not looked at yet
✖️ Unnecessary
🛑 Blocked
All Rulesets
| Check | Status | Difficulty | Priority |
|---|---|---|---|
| Missing background. | ✔️ ppy#12361 | ★ | 0 |
| Multiple or missing audio files. | ✔️ ppy#12492 🛑 Can't check multiple¹. | ★ | 0 |
| Inconsistent or unset preview time. | ✔️ ppy#22281 | ★ | 0 |
| Inconsistent metadata. | 🛑 ¹ 🟡 ² | ★ | 0 |
| Inconsistent uninherited lines, meter signatures or BPM. | 🛑 ¹ | ★ | 0 |
| Too high or low audio bitrate. | ✔️ ppy#12492 | ★★ | 0 |
| Unsnapped hitobjects. | ✔️ ppy#12588 | ★★ | 0 |
| Concurrent hitobjects. | ✔️ ppy#12588 | ★★ | 0 |
| Inconsistent mapset id, countdown, epilepsy warning, etc. | 🛑 ¹ 🟡 ² | ★★ | 0 |
| Low volume hitsounding. | ✔️ ppy#13669 | ★ | 1 |
| Too short hitsounds. | ✔️ ppy#13871 | ★ | 1 |
| 0-byte files. | ✔️ ppy#13871 | ★ | 1 |
| Inconsistent video usage. | 🛑 ¹ | ★ | 1 |
| Objects too close together. | ❌ (< 10 ms) | ★ | 1 |
| Too high or low background resolution. | ✔️ ppy#12492 | ★★ | 1 |
| Lowest difficulty too difficult for the given drain/play time(s). | 🛑 ¹ | ★★ | 1 |
| Audio channels in video. | ✔️ ppy#13871 | ★★ | 1 |
| Delayed hitsounds. | ✔️ ppy#24648 | ★★★ | 1 |
| Wrongly or inconsistently snapped hitobjects. | 🛑 ¹ | ★★★ | 1 |
| Too high video resolution. | ❌ | ★ | 2 |
| Missing genre/language in tags. | 🟡 Not PRed yet | ★ | 2 |
| Unicode in romanized fields. | 🟡 Not PRed, will batch together with other metadata checks. | ★ | 2 |
| Abnormal difficulty settings. | ❌ | ★ | 2 |
| Too short drain time. | ✔ppy#24175 | ★ | 2 |
| Zero-length objects. | ✔️ ppy#13874 | ★ | 2 |
| Too high sprite resolution. | ❌ | ★★ | 2 |
| Incorrect marker format. | ❌ | ★★ | 2 |
| Incorrect marker spacing. | ❌ | ★★ | 2 |
| Incorrect format of (TV Size) / (Game Ver.) / (Short Ver.) / (Sped Up Ver.) in title. | ❌ | ★★ | 2 |
| More than 20% unused audio at the end. | ❌ | ★★ | 2 |
| Incorrect hitsound format. | ❌ | ★★ | 2 |
| Slider tick rates not aligning with any common beat snap divisor. | ❌ | ★★ | 2 |
| Unused timing lines. | ❌ Possibly unnecessary. Made to prevent shifts in timing due to uninherited lines rounding their time to an integer, even when the cursor is at a decimal time (e.g. snapped to prior timing). May work differently in lazer. | ★★ | 2 |
| Overlay layer usage. | ❌ | ★ | 3 |
| Inconsistent video offset. | 🛑 ¹ | ★ | 3 |
| Unsnapped kiai. | ❌ | ★ | 3 |
| Abnormal amount of slider nodes. | ❌ | ★ | 3 |
| First line toggles kiai or is inherited. | ❌ Possibly unnecessary. Nothing to inherit, causing undefined behaviour. Kiai causes the entire intro prior to the line to act as if in kiai. May work differently in lazer. | ★ | 3 |
| Incorrect audio format. | ❌ | ★★ | 3 |
| Imbalanced hitsounds. | ❌ | ★★ | 3 |
| Breaks only achievable through .osu editing. | ✔ ppy#24259 | ★★ | 3 |
| Frequent finish hitsounds. | ❌ | ★★★ | 3 |
| Concurrent or conflicting timing lines. | ✖️No longer be possible with the new control point system. It is possible to add another point 0.000001 ms earlier/later, but doesn't seem worth implementing a check for. | - | - |
| Unused files. | ✖️ Unused files are automatically removed. | - | - |
| Issues with updating or downloading. | ✖️ Made to prevent bugs specifically in stable and its interaction with BSS. Could feasibly be made into upload restrictions in lazer if anything is still an issue. | - | - |
osu!-specific
| Check | Status | Difficulty | Priority |
|---|---|---|---|
| Long periods without hitsounding. | ✔️ ppy#13669 + checks other rulesets as well (TODO: probably need to exclude taiko, though). | ★★ | 0 |
| Offscreen hitobjects. | ✔️ ppy#12361 | ★★ | 0 |
| Hitobject is unaffected by a line very close to it. | ❌ | ★★ | 0 |
| Object too close or far away from previous. | ✔️ ppy#13606 | ★★★ | 0 |
| Multiple reverses on too short sliders. | ❌ | ★ | 1 |
| Too short sliders. | ✔️ ppy#13874 | ★ | 1 |
| Too short spinner. | ✔️ ppy#13874 | ★ | 1 |
| Objects close in time not overlapping. | ✔️ ppy#13606 + checks when it should overlap too. | ★★ | 1 |
| Too short spinner time or spinner recovery time. | ✔️ppy#24622 | ★★ | 1 |
| Perfect stacks too close in time. | ❌ | ★ | 2 |
| Too dark or bright combo colours or slider borders. | ❌ | ★★ | 2 |
| Perfectly overlapping combination of tail, head or red anchors. | ❌ | ★★ | 2 |
| Obscured reverse arrows. | ❌ | ★★ | 2 |
| Burai slider. | ❌ | ★★★ | 2 |
| Default combo colours without forced skin. | ❌ | ★ | 3 |
| Storyboarded hitsounds. | ❌ | ★★ | 3 |
¹ - Editor lacks context of other difficulties, so any check that compares difficulties cannot be implemented.
² - Not PRed. Didn't realize it wouldn't work in-game, but will keep checks & tests around for whenever this gets unblocked.