Compilation Issue

Question

Compilation Issue

codeeleven0 opened this issue a year ago · comments

cc fails at gettimeofday(&ev.time, NULL); with error fbink_button_scan.h:70:41: error: 'struct input_event' has no member named 'time'. I am using a Kobo Aura Second Edition and it doesn't have any hardware buttons. Is there any way to disable the compilation of this file?

Mustafa E · Answer 1 · Fri Sep 15 2023 21:14:31 GMT+0800 (China Standard Time)

Just solved by editing the Makefile.

NiLuJe · Answer 2 · Fri Sep 15 2023 22:31:35 GMT+0800 (China Standard Time)

You also appear to be using a really old toolchain (or at least really, really old kernel headers), which might not be a great idea.

c.f., https://github.com/koreader/koxtoolchain

Because, yeah, while, button_scan is essentially deprecated here, not being able to deal with input_event will be... problematic if you ever need to do any kind of input handling ;o).

Mustafa E · Answer 3 · Sat Sep 16 2023 01:25:50 GMT+0800 (China Standard Time)

I tried to compile FBInk that comes with fbink-xdamage with the latest Alpine Linux chroot at my Kobo Aura SE. Then I encountered the error. So, I modified some files and it worked! Then I created a fork of FBInk and modified it for my Kobo Aura SE. After that, I forked fbink-xdamage and added my fork as a submodule. Gonna test it later. Just removed lines that add the button scanner from the Makefile and removed the import from fbink.c. If you add my fork of FBInk for Kobo Aura SE users (https://github.com/codeeleven0/FBInk-AuraSE) to the README file, I'd be really happy. Android için Outlook<https://aka.ms/AAb9ysg> edinin

…

________________________________ From: NiLuJe ***@***.***> Sent: Friday, September 15, 2023 5:31:45 PM To: NiLuJe/FBInk ***@***.***> Cc: Mustafa E ***@***.***>; State change ***@***.***> Subject: Re: [NiLuJe/FBInk] Compilation Issue (Issue #75) You also appear to be using a really old toolchain (or at least really, really old kernel headers), which might not be a great idea. c.f., https://github.com/koreader/koxtoolchain Because, yeah, while, button_scan is essentially deprecated here, not being able to deal with input_event will be... problematic if you ever need to do any kind of input handling ;o). — Reply to this email directly, view it on GitHub<#75 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXDUEN7PPMTLPQVIHN24TSDX2RRFDANCNFSM6AAAAAA4ZXLMS4>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

Nathaniel van Diepen · Answer 4 · Sat Sep 16 2023 01:30:06 GMT+0800 (China Standard Time)

Any reason you are wanting to add a fork instead of upstreaming the changes behind a flag similar to the KINDLE, LEGACY, POCKETBOOK, CERVANTES, and REMARKABLE flags?

Mustafa E · Answer 5 · Sat Sep 16 2023 01:43:03 GMT+0800 (China Standard Time)

Any reason you are wanting to add a fork instead of upstreaming the changes behind a flag similar to the KINDLE, LEGACY, POCKETBOOK, CERVANTES, and REMARKABLE flags?

I want to make things easier.
I am creating an install-script for installing Alpine and a minimal desktop on my Kobo Aura SE. Everytime I try it I don't want to hassle with configs, so I created forks, which will help me a lot.

NiLuJe · Answer 6 · Sat Sep 16 2023 12:33:17 GMT+0800 (China Standard Time)

There's no need to hack around it, the Makefile is already modular (c.f., https://github.com/NiLuJe/FBInk#how-do-i-build-it).

i.e., make sharedlib KOBO=1 SHARED=1 MINIMAL=1 will probably be enough for xdamage, and you'll get a (much) smaller library to boot. (If in doubt, pass DRAW=1, too, but IIRC, it just needs to be able to refresh).

Mustafa E · Answer 7 · Sat Sep 16 2023 14:01:50 GMT+0800 (China Standard Time)

But I am compiling FBInk from fbink-xdamage. Because of that I created a fork with some hacks.

…

________________________________ From: NiLuJe ***@***.***> Sent: Saturday, September 16, 2023 7:33:27 AM To: NiLuJe/FBInk ***@***.***> Cc: Mustafa E ***@***.***>; State change ***@***.***> Subject: Re: [NiLuJe/FBInk] Compilation Issue (Issue #75) There's no need to hack around it, the Makefile is already modular (c.f., https://github.com/NiLuJe/FBInk#how-do-i-build-it). i.e., make kobo MINIMAL=1 will probably be enough for xdamage, and you'll get a (much) smaller library to boot. (If in doubt, pass DRAW=1, too). — Reply to this email directly, view it on GitHub<#75 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXDUEN3GCAL5S53GQPFDHR3X2UTZPANCNFSM6AAAAAA4ZXLMS4>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

NiLuJe · Answer 8 · Sat Sep 16 2023 22:31:10 GMT+0800 (China Standard Time)

That sure sounds easier than just updating one line...

diff --git a/Makefile b/Makefile
index 8d77bbb..c99c0ed 100644
--- a/Makefile
+++ b/Makefile
@@ -1,3 +1,3 @@
 all:
-       (cd FBInk; make shared KOBO=1)
+       make -C FBInk sharedlib SHARED=1 KOBO=1 MINIMAL=1
        gcc -LFBInk/Release/ -IFBInk main.c -o fbink_xdamage -lX11 -lXext -lXdamage -lXfixes -lfbink

NiLuJe · Answer 9 · Sat Sep 16 2023 22:34:16 GMT+0800 (China Standard Time)

And as far as xdamage is concerned, schuhumi/fbink-xdamage@de2e6de may be relevant to your interests ;).

Mustafa E · Answer 10 · Sun Sep 17 2023 00:44:52 GMT+0800 (China Standard Time)

I am making a shortcut for an automated script in NickelMenu. So, it would be easier to run and repos are up to date.