Nheko-Reborn / nheko

Desktop client for Matrix using Qt and C++20.

Home Page:https://nheko-reborn.github.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

no way to activate encryption using recovery passphrase

foresto opened this issue · comments

Describe the bug

The Activate Encryption dialog explains that it can be done by entering the account's recovery passphrase, and directs the user to select the corresponding option "below", but does not offer any such option.

To Reproduce

  1. Log in to a new session, or click the Unverified Login banner on an existing one.
  2. Read the Activate Encryption dialog.
  3. Look for the recovery passphrase option.

What happened?

The recovery passphrase option doesn't exist.

Expected behavior

The recovery passphrase option should exist.

Screenshots

activate encryption

Version

0.12.0

Operating system

Linux

Installation method

Local build

Qt version

org.kde.Sdk 6.6 flathub

C++ compiler

whatever the flatpak manifest uses

Desktop Environment

KDE Plasma 5.27.5 (debian stable)

Did you use profiles?

  • Profiles used?

Relevant log output

No response

Backtrace

No response

The recovery phrase option is only shown, if that is actually supported for your account. You probably don't have SSSS enabled?

You probably don't have SSSS enabled?

That's possible. It was a test account that I hadn't used for much, and hadn't used in a long time.

Nevertheless, the UI was confusing: The banner appeared every time I connected, giving me the impression that I must have enabled recovery in the past. (Because if I hadn't ever used this account for e2ee messaging, and didn't intend to, why would the app be constantly nagging me to verify devices?)

Also, I guess I assumed that the app would detect whether a recovery phrase was set, and adjust its prompt accordingly. Reading it again now, I see how it didn't actually state that I had one, but it nevertheless gave me that impression on first reading.

The app does adjust the prompt, it removes the passphrase button if there is no passphrase to enter. The wording of the explanation could probably be improved as well as an option be added to reset your cross-signing. Currently you need Element for the latter, but the button not being present is not a bug.

The wording of the explanation could probably be improved

Indeed. By "prompt", I meant the wording, not the controls.

the button not being present is not a bug.

Fair enough, but the text, "Please select one of the options below," suggests that a second selectable option should be present, while there isn't one. And the text, "If you choose 'enter passphrase'," suggests that an "enter passphrase" option should be present, but it isn't either.

Also, the text uses the conditional phrase "(if you have one)" when referring to a device that might not exist, but doesn't do the same when referring to a recovery passphrase that might not exist.

The point of this issue is that (even if the controls are behaving as intended) the user is directed to do something that can't be done here. Perhaps I should have made that more obvious in the title.