NeuromatchAcademy / course-content

NMA Computational Neuroscience course

Home Page:https://compneuro.neuromatch.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue on function my_illus_LIFSYN(pars, v_fmp, v)

eduardoconto opened this issue · comments

For coding exercise 1.2, changing the threshold doesn't seem to have any effect.
I think there is a bug in def my_illus_LIFSYN(pars, v_fmp, v)

Line
  plt.axhline(-55, 0, 1, color='k', lw=2., ls='--',
              label='Spike Threshold', zorder=1
 Should be 
 plt.axhline(pars['V_th'], 0, 1, color='k', lw=2., ls='--',
              label='Spike Threshold', zorder=1)

Good catch, thanks. #830 fixed the hardcoded value.