NeuromatchAcademy / course-content

NMA Computational Neuroscience course

Home Page:https://compneuro.neuromatch.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Generalized Linear Models, Tutorial 2, Coding Exercise 2.4 Solution. --student feedback

faezesarlakifar opened this issue · comments

It is good to consider the actual formula for accuracy. It is correct here because all of the record predictions are accurate, resulting in a 100% accuracy rate, even when calculating the mean value. However, providing a clearer explanation of the accuracy formula, especially since it is defined here for the first time, would be beneficial. I suggest changing this line:

From: "accuracy = (y == y_pred).mean()"
To: "accuracy: (y == y_pred).sum() / len(y)"

@mstimberg @mwaskom @bgalbraith @Visdoom

@faezesarlakifar Thank you for your feedback. We will change this in next iteration of updates and fixes.