Giters

NeoTech-Software / Android-Root-Coverage-Plugin

A Gradle Plugin for Android developers that automatically configures Jacoco code coverage tasks for both combined and per module coverage reports, easier than ever.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Misleading warning

emartynov opened this issue · comments

commented

Super thank you for the work under the plugin.

We have next project structure:

root 
   features 
      registration
      fit
      ...
  core
     network
     ...
  app

We are getting warning that projects features and core are not supported. However, they are not projects but just container folders.

commented

@emartynov this is something I will fix in the next release.

commented

In the next release instead of a warning this will likely become something like this:

Notice: skipping module x because Android Gradle Plugin was not detected

Which is also not going to be logged on the WARNING level but on the INFO level.

commented

Rolf, it is still misleading since they are not modules

commented

From a Gradle perspective they are actually seen as modules (that is also why the warning is triggered for those in the first place), so it might be hard to differentiate.

But I will see what I can do.

commented

Fixed in #50, will be released in version 1.5.

commented

I've added a check which checks if a Gradle sub(project) is an empty container for other (sub)projects, like in your case. If that is the case it will not log a message. "empty container" means in this case that there is no build.gradle file in that folder.

This is released with version 1.5.0.